Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces a reusable git workflow #33

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Introduces a reusable git workflow #33

merged 8 commits into from
Dec 7, 2023

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Dec 5, 2023 •
edited
Loading

Resolves #25

SEE IT IN USE HERE

Workflow takes in the following inputs:

    inputs:
      cli-version:
        required: false
        description: "Version of BOS CLI to use for deploy (e.g. 0.3.0)"
        type: string
        default: "0.3.6"
      deploy-env:
        required: false
        description: "Environment to deploy component code to (e.g. mainnet, testnet)"
        type: string
        default: "mainnet"
      app-name:
        required: true
        description: "Workspace app name to deploy (from /apps directory)"
        type: string
      deploy-account-address:
        required: true
        description: "Account under which component code should be deployed"
        type: string
      signer-account-address:
        required: true
        description: "Account which will be used for signing deploy transaction, frequently the same as deploy-account-address"
        type: string
      signer-public-key:
        required: true
        description: "Public key for signing transactions in the format: `ed25519:<public_key>`"
        type: string
    secrets:
      SIGNER_PRIVATE_KEY:
        description: "Private key in `ed25519:<private_key>` format for signing transaction"
        required: true
  • It allows to be passed environment (so can be reused for mainnet, testnet, and preview deploy)
  • It takes in an app name, so workflows can be created per app

It currently downloads and installs bos-cli-rs; it may be an improvement to replace with a bos deploy command (but bos deploy should be able to take app name)

sekaiking
sekaiking previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@sekaiking sekaiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we add the usage example in the README?

@elliotBraem elliotBraem merged commit d642dc9 into main Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sekaiking sekaiking sekaiking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git workflow templates for mainnet, testnet, and preview branches
2 participants
@elliotBraem @sekaiking